Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hostNetwork support in eck-operator Helm chart #6636

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Enable hostNetwork support in eck-operator Helm chart #6636

merged 5 commits into from
Apr 12, 2023

Conversation

KrisJohnstone
Copy link
Contributor

@KrisJohnstone KrisJohnstone commented Apr 2, 2023 •
edited
Loading

Enable support for webhooks for those of us whom are using alternate CNIs.

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 2, 2023 •
edited
Loading

💚 CLA has been signed

@botelastic botelastic bot added the triage label Apr 2, 2023
@KrisJohnstone
Copy link
Contributor Author

I most certainly did sign the agreement.

@thbkrkr thbkrkr added >feature Adds or discusses adding a feature to the product v2.8.0 labels Apr 3, 2023
@botelastic botelastic bot removed the triage label Apr 3, 2023
KrisJohnstone and others added 2 commits April 5, 2023 09:42
@KrisJohnstone @thbkrkr
Update deploy/eck-operator/values.yaml
992f0b9 
chore: update hostNetwork description to nicer description.

Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
@KrisJohnstone
fix: move hostNetwork bool to webhook
8cf557c
@thbkrkr thbkrkr mentioned this pull request Apr 5, 2023
Closed
@thbkrkr thbkrkr changed the title feat: add hostNetworking support Enable hostNetwork support in eck-operator Helm chart Apr 6, 2023
@thbkrkr thbkrkr requested a review from naemono April 6, 2023 16:04
naemono
naemono reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be good with this after the suggested CAUTION suggestion from @thbkrkr .

deploy/eck-operator/templates/statefulset.yaml Show resolved Hide resolved
@thbkrkr
Copy link
Contributor

thbkrkr commented Apr 12, 2023

buildkite test this

@thbkrkr
Copy link
Contributor

thbkrkr commented Apr 12, 2023

@elasticmachine run elasticsearch-ci/docs

@thbkrkr thbkrkr merged commit eb2e408 into elastic:main Apr 12, 2023
@thbkrkr thbkrkr added >enhancement Enhancement of existing functionality and removed >feature Adds or discusses adding a feature to the product labels Apr 13, 2023
@thbkrkr thbkrkr mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbkrkr thbkrkr thbkrkr approved these changes

@naemono naemono naemono approved these changes

Assignees
No one assigned
Labels
>enhancement Enhancement of existing functionality v2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KrisJohnstone @thbkrkr @naemono